fix(api/hook): handle 202 error for webhook redelivery #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 55.17% 55.15% -0.02%
==========================================
Files 195 195
Lines 15896 15901 +5
==========================================
Hits 8770 8770
- Misses 6753 6758 +5
Partials 373 373
|
…ver into fix/add-accepted-error-check
JordanSussman
approved these changes
Jun 1, 2022
wass3r
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GitHub adds the redelivery job to their queue, they respond with a
202. That is passed down as an error fromgo-githubwith the body"job scheduled on GitHub side; try again later". We don't want to have a user try again later because once the job get pulled off the queue, it's successful.So, in the code, I decided to check for that 202 status and shortcut the error checking in the case that the status matches. In my local testing, 100% of my calls to redeliver have resulted in a 202.